fix: emit connect once all handshake commands have been resolved #2040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PavelPashov
force-pushed
the
fix/pubsub-on-connect-issues
branch
from
0869378 to
2ed91b2
Compare
PavelPashov
force-pushed
the
fix/pubsub-on-connect-issues
branch
2 times, most recently
from
eda55a0 to
9dc4f39
Compare
PavelPashov
force-pushed
the
fix/pubsub-on-connect-issues
branch
from
9dc4f39 to
f1012bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to resolve race conditions when a
(p)subscribeis issued duringconnectstatus. Currently it's possible to either send aclientorinfohandshake command after the(p)subscribecommand has been issued and this might result either in the client rejecting the non-subscriber related command or the server rejecting it depending on the timing when the subscriber command was issued. This fix might lead to a situation in which some of the handshake commands are not sent to the server, however for example the ready check, which sends theinfocommand does not make sense to happen on a subscriber connection, since the connection can only issue subscriber mode commands to the server.Fixes #2037